GitHub Commit Status for "deploy/netlify" doesn't report "successful"

We recently updated our repository to use the latest version of the Netlify app for GitHub, so that we could get preview deploy checks reported on our PRs.

The preview builds are deploying fine, but the checks do not report “successful” on the PR on GitHub - they only report as “completed”.

I have set up the deploy notifications to add rich commit info on both success as well as failure. Any idea how to get GitHub to recognize when a preview deployment has succeeded?

Hi @mdlincoln, the one that is staying yellow is actually a Github Commit Status notificiation (https://docs.netlify.com/site-deploys/notifications/#github-commit-statuses). Can you check that you have one set up for that as well?

Also, I’ve updated the title of the post to be more accurate.

Thanks - I believe I’ve got github commit status notifications set up now. This is now how the checks report:

The first deploy/netlify status is still there, and still reports as “waiting for status to be reported”?

A link to the PR in question: https://github.com/programminghistorian/jekyll/pull/1606

I’ve now tried completely deleting the site and re-creating it from scratch, leaving all the default notifications intact:

Making a brand new PR after this still results in a successful deploy but incomplete github commit checks:

@Dennis do you have any ideas why a completely fresh Netlify site using the default configuration would still not be reporting successful commit statuses?

@Dennis this is still a problem, even for brand new PRs! Is there anything currently missing in our configuration that would be causing this?

For anyone else stuck with this: currently we’re using a workaround on the GitHub side: only requiring the netlify/ph-preview/deploy checks on our branch protection rules, and not the misbehaving netlify/deploy checks:

Hi, @mdlincoln, and thank you for your patience with this.

When I checked this site, I don’t see a notification for “deploy succeeded” as being one of the notifications configured.

I know you have a workaround in place now but if you are willing to test adding the success notification would you please let us know if it works? Here is a screenshot of the notification missing:

screenshot

If this doesn’t resolve the issue when tested, please let us know and we’ll keep troubleshooting.

Sorry to hijack this thread. It seems Netlify is not using the Github Deployments API correctly.
I run https://checklyhq.com and we trigger specific actions based on Github Deployment hooks.
This works perfectly for deployments done by companies like Zeit and Heroku. However, Netlify seems to not trigger the correct deployment status updates as per the Github API, https://developer.github.com/v3/repos/deployments/

I would love for our customers to use Checkly on their Netlify deployments, but there is no way for us now to find out when a deployment is finished.

We don’t use the github deployments API at all, Tim. That’s not a bug, it’s how we intend to roll :slight_smile:
I have added your voice to the feature requests that we DO use that API, but there is no work planned to do so.

To others who may run into this issue: this could be due to account-level commit status notifications, which you can find here:
https://app.netlify.com/teams/YOUR-SITE/settings/sites#notifications

If you run into this hanging “deploy/netlify” status, try changing the setting there to “One notification per repo”